Feature/masking #74
Merged
Feature/masking #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bustikiller, I re-implemented your feature requests slightly differently - would you mind taking a look and let me know a) what you think and b) if this works for your use case? Thanks! |
trusche
commented
May 13, 2019
| string_classes << URI::HTTP if defined?(URI::HTTP) | ||
| string_classes << HTTP::FormData::Urlencoded if defined?(HTTP::FormData::Urlencoded) | ||
| string_classes | ||
| end |
There was a problem hiding this comment.
This is important to avoid dependencies on http libraries that are not used...
trusche
commented
May 13, 2019
| case msg | ||
| when *string_classes | ||
| config.filter_parameters.reduce(msg) do |m,key| | ||
| m.to_s.gsub(/(#{key})=[^&]+/i, "#{key}=#{PARAM_MASK}") |
There was a problem hiding this comment.
This is a bit more robust, just \w+ would only replace up to the first possible whitespace, URL encoded or not. Not terribly pretty but is might suffice and is less complex than parsing the full query string into a hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.