Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graylog adaptation #83

Merged
merged 3 commits into from
Nov 14, 2019
Merged

Conversation

Meat-Chopper
Copy link
Contributor

No description provided.

@Meat-Chopper Meat-Chopper force-pushed the graylog_adaptation branch 2 times, most recently from c226090 to 935f294 Compare November 12, 2019 07:41
@trusche
Copy link
Owner

trusche commented Nov 13, 2019

Hiya @Meat-Chopper, this is great, thanks for the PR. If you could add some tests that cover the new feature, I'd be happy to merge this.

@Meat-Chopper
Copy link
Contributor Author

Hello @trusche, the tests have been added

Copy link
Owner

@trusche trusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments...

spec/lib/http_client_spec.rb Show resolved Hide resolved
spec/spec_helper.rb Outdated Show resolved Hide resolved
@trusche trusche merged commit 29e46da into trusche:master Nov 14, 2019
@Meat-Chopper
Copy link
Contributor Author

Thank you!

@trusche
Copy link
Owner

trusche commented Nov 14, 2019

Published as v1.3.3. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants