-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle platforms where c_int is not i32 #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daringer
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the test fails because it's missing the std source I think
Yeah, since rebasing onto main the CI fails, but the same commands worked before. Not sure why it fails now:
But we already installed
|
robin-nitrokey
added a commit
that referenced
this pull request
Aug 15, 2024
This patch applies those changes from #69 that affect the core crate.
And another rebase fixed it. 🤔 |
sosthene-nitrokey
approved these changes
Aug 16, 2024
daringer
approved these changes
Sep 10, 2024
Some functions assume that c_int is always i32. This is not true for all platforms. This patch adapts those functions to handle those cases. Some littlefs functions return an error code (c_int) from functions returning i32. In these cases, error codes are truncated to c_int::MIN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CI job that tests compatibility with an avr target (16-bit) and fixes code that assumes that
c_int
is alwaysi32
.Replaces:
One remaining problem is that some functions cast
u32
return values tousize
. In most cases that should be fine because the return value is limited by the length of the input buffer and thus fits into ausize
. One notable exemption isseek
. But let’s review and fix that separately.