Make more items public #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
public-items
branch
from
c515afc
to
e9caedb
Compare
This is useful for factory resets in other implementations that might need to parse all the Pin data and don't use the delete_all filestore methods.
sosthene-nitrokey
force-pushed
the
public-items
branch
from
5ae0453
to
98eb1e5
Compare
robin-nitrokey
approved these changes
Nov 13, 2023
src/lib.rs
Outdated
Comment on lines
151
to
169
| let msb = match path[0] { | ||
| b'0' => 0x0, | ||
| b'1' => 0x1, | ||
| b'2' => 0x2, | ||
| b'3' => 0x3, | ||
| b'4' => 0x4, | ||
| b'5' => 0x5, | ||
| b'6' => 0x6, | ||
| b'7' => 0x7, | ||
| b'8' => 0x8, | ||
| b'9' => 0x9, | ||
| b'a' => 0xa, | ||
| b'b' => 0xb, | ||
| b'c' => 0xc, | ||
| b'd' => 0xd, | ||
| b'e' => 0xe, | ||
| b'f' => 0xf, | ||
| _ => return Err(PinIdFromStrError), | ||
| }; |
There was a problem hiding this comment.
If we are this verbose, can we use a helper function so that we only have to do it once? Or maybe just use something like this:
fn parse_ascii_hex(a: u8) -> Option<u8> {
match a {
b'0'..=b'9' => Some(a - b'0'),
b'a'..=b'f' => Some(a - b'a' + 0xA),
_ => None,
}
}
There was a problem hiding this comment.
This prompted me to look for a std solution and actually u8::from_str_radix is available in core so let's use that instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes more items public to enable other backends to implement the extension interface.
Motivated by the se050 backend, so this will stay as draft until the backend implements the trussed-auth functionality to avoid having many small PR for similar issues.