Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: Pagination a11y issue on role attribute #2916

Open
rylew1 opened this issue May 7, 2024 · 0 comments
Open

[fix]: Pagination a11y issue on role attribute #2916

rylew1 opened this issue May 7, 2024 · 0 comments
Labels
type: bug Something isn't working like it's supposed to

Comments

@rylew1
Copy link

rylew1 commented May 7, 2024

ReactUSWDS Version & USWDS Version:

Describe the bug

To Reproduce
Steps to reproduce the behavior:

  1. Add a Pagination component

  2. Run LIghthouse with a11y checked:
    image

  3. Observe a11y issue flagged by Lighthouse:
    image

Expected behavior

No a11y issues reported

Additional context

It looks like dependabot updated things from uswds here: #2556
If you look at the release notes you'll see the Pagination issue looks like it was fixed:
image

But the dependabot update didn't replace the role attribute in the Pagination component.

We need to replace the role attribute with this: aria-label="ellipsis indicating non-visible pages"

Device and Browser Information (please complete the following information if describing a UI bug):

  • OS: Mac
  • Browser: chrome
  • Version @trussworks/react-uswds: 7.0.0
  • Version @uswds/uswds: ^3.6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working like it's supposed to
Projects
None yet
Development

No branches or pull requests

1 participant