Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uni-registrar-web image #514

Merged
merged 1 commit into from
Oct 23, 2020
Merged

fix: uni-registrar-web image #514

merged 1 commit into from
Oct 23, 2020

Conversation

fqutishat
Copy link
Contributor

Signed-off-by: Firas Qutishat firas.qutishat@securekey.com

@cla-bot cla-bot bot added the cla-signed label Oct 23, 2020
Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com>
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c556e6f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #514   +/-   ##
=========================================
  Coverage          ?   87.34%           
=========================================
  Files             ?       26           
  Lines             ?     2260           
  Branches          ?        0           
=========================================
  Hits              ?     1974           
  Misses            ?      162           
  Partials          ?      124           
Impacted Files Coverage Δ
cmd/did-rest/startcmd/start.go 86.41% <0.00%> (ø)
pkg/restapi/holder/controller.go 100.00% <0.00%> (ø)
pkg/restapi/verifier/controller.go 100.00% <0.00%> (ø)
pkg/restapi/verifier/operation/operations.go 89.14% <0.00%> (ø)
cmd/common/common.go 100.00% <0.00%> (ø)
pkg/restapi/governance/operation/operations.go 84.68% <0.00%> (ø)
pkg/restapi/holder/operation/operations.go 91.91% <0.00%> (ø)
cmd/vc-rest/startcmd/start.go 85.60% <0.00%> (ø)
pkg/restapi/did/controller.go 100.00% <0.00%> (ø)
pkg/internal/cryptosetup/cryptosetup.go 79.10% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c556e6f...cd950d1. Read the comment docs.

@llorllale
Copy link
Contributor

@fqutishat please indicate the reason for this change and why we're to use this image

@fqutishat
Copy link
Contributor Author

fqutishat commented Oct 23, 2020

@fqutishat please indicate the reason for this change and why we're to use this image

latest image of universalregistrar/uni-registrar-web not working. I open issue decentralized-identity/universal-registrar#16

@fqutishat
Copy link
Contributor Author

we use this image until they fix universalregistrar/uni-registrar-web

@fqutishat fqutishat merged commit 46351d1 into trustbloc:master Oct 23, 2020
@fqutishat fqutishat deleted the fix branch October 23, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants