Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detected os.name when running on Apple Silicon M1 #58

Closed
aalmiray opened this issue Jun 6, 2021 · 1 comment · Fixed by #67
Closed

Detected os.name when running on Apple Silicon M1 #58

aalmiray opened this issue Jun 6, 2021 · 1 comment · Fixed by #67
Milestone
1.7.1

Comments

@aalmiray
Copy link

aalmiray commented Jun 6, 2021

Apparently Zulu reports the value of "os.name" to be "Mac".
The code currently looks for "macosx" or "osx".
@tresf
Copy link

tresf commented Jul 29, 2021

Hmm... Homebrew's OpenJDK 16.0.1, os.name returns Mac OS X, but ${os.detected.name} still comes back as osx. Any idea why it doesn't behave the same?

$(brew --prefix openjdk)/bin/java -XshowSettings:properties -version 2>&1 |grep os.name
#    os.name = Mac OS X

trustin added a commit that referenced this issue Nov 7, 2022
@trustin
Detect more osx variants
61bb4fb 
Motivation:

It looks like some JDK implementations do neither return `macosx` or
`osx` for `System.getProperty("os.arch")`.

Modifications:

- Return `osx` when `os.arch` starts with `mac` instead of `macosx`,
  so that the plugin detects both `mac` and `macosx`.

Result:

- Fixes #58
@trustin trustin mentioned this issue Nov 7, 2022
Merged
trustin added a commit that referenced this issue Nov 7, 2022
@trustin
Detect more osx variants (#67)
88bae1e 
Motivation:

It looks like some JDK implementations do neither return `macosx` or `osx` for `System.getProperty("os.arch")`.

Modifications:

- Return `osx` when `os.arch` starts with `mac` instead of `macosx`, so that the plugin detects both `mac` and `macosx`.

Result:

- Fixes #58
@trustin trustin added this to the 1.7.1 milestone Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.1
Development

Successfully merging a pull request may close this issue.

Detect more osx variants trustin/os-maven-plugin
3 participants
@aalmiray @trustin @tresf