Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eclipse-related documentation and metadata updates #37

Merged
merged 1 commit into from
Oct 13, 2018
Merged

Eclipse-related documentation and metadata updates #37

merged 1 commit into from
Oct 13, 2018

Conversation

sergei-ivanov
Copy link
Contributor

  • Added the default m2e lifecycle mapping
  • Updated README to include additional workarounds for Eclipse

@sergei-ivanov
Eclipse-related documentation and metadata updates
6f5b1eb 
* Added the default m2e lifecycle mapping
* Updated README to include additional workarounds for Eclipse
@sergei-ivanov
Copy link
Contributor Author

Supplementary notes:
This PR summarises various workarounds for Eclipse integration problems, as suggested by protobuf-maven-plugin community. Please see xolstice/protobuf-maven-plugin#10, xolstice/protobuf-maven-plugin#18, xolstice/protobuf-maven-plugin#41.

@szab100
Copy link

szab100 commented Sep 26, 2018 •
edited
Loading

Tested, works like a charm! If this gets merged, how quickly can a release be made, as this fixes major issues with Eclipse? @trustin ?

@szab100
Copy link

szab100 commented Oct 3, 2018

Hey @sergei-ivanov, could you please add @trustin as a reviewer, so he might take a look when he has some time?

@sergei-ivanov
Copy link
Contributor Author

I cannot appoint him as a reviewer, but he is the owner of the project and I am sure he is receiving these notifications. Please be patient: people are busy and some changes may take time.

@sergei-ivanov
Copy link
Contributor Author

Related to #34

@trustin
Copy link
Owner

trustin commented Oct 4, 2018

Sorry for getting late on this. Will check soon. Thanks for the head up!

@trustin trustin self-requested a review October 4, 2018 06:59
@trustin trustin added this to the 1.6.1 milestone Oct 13, 2018
@trustin trustin merged commit 02fcb78 into trustin:master Oct 13, 2018
@trustin
Copy link
Owner

trustin commented Oct 13, 2018

Thanks a lot for your patience. Will release 1.6.1 today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trustin trustin trustin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@sergei-ivanov @szab100 @trustin