Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade web3 from 5.0.0b2 to 5.0.0b4 #263

Merged
merged 1 commit into from Jul 26, 2019
Merged

Upgrade web3 from 5.0.0b2 to 5.0.0b4 #263

merged 1 commit into from Jul 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 25, 2019

ethpm has been integrated into web3. That means we can get rid of the
workaround for missing dependencies.

Before upgrading to this version, the standalone ethpm package has to
be manually uninstalled.

The following PR has been merged into 5.0.0b4, which is the primary
reason for the upgrade:

ethereum/web3.py#1378

ethpm has been integrated into web3. That means we can get rid of the
workaround for missing dependencies.

Before upgrading to this version, the standalone ethpm package has to
be manually uninstalled.

The following PR has been merged into 5.0.0b4, which is the primary
reason for the upgrade:

  ethereum/web3.py#1378
@ghost ghost added this to the 25.07.2019 milestone Jul 25, 2019
@ghost ghost requested a review from saschagoebel July 25, 2019 21:29
This was referenced Jul 25, 2019
@saschagoebel saschagoebel merged commit 78ba973 into trustlines-protocol:live-test-fixes Jul 26, 2019
saschagoebel added a commit that referenced this pull request Jul 26, 2019
* Add missing gas price parameter

* Make loglevel configurable via environment

* Config file is optional, because the application can be configured via Environment as well.

* Improve parameter validation & implicitly typecast int and float values. Invalid values will throw a ValueError anyway.

* Make RPC timeouts configurable

* Sort config keys

* Update Example Config with Ropsten Test Values

* Formatting

* Fix tests

* Fix float check & change poll interval to int

* Make event fetcher a bit more verbose on info level

* Update Test-Token Address

* Use Checksummed address

* Add missing library versions to constraints.txt

* Rename token_contract_address to foreign_chain_token_contract_address

* Fix Nonce Calculation, GasPrice & ChainId

* Cleanup pre-commit, so that just python3 is required

* Fix tests, but this will likely not work in production (chainId)

* Update example to reflect new config parameter name for token bridge

* Formatting

* Upgrade web3 from 5.0.0b2 to 5.0.0b4 (#263)

ethpm has been integrated into web3. That means we can get rid of the
workaround for missing dependencies.

Before upgrading to this version, the standalone ethpm package has to
be manually uninstalled.

The following PR has been merged into 5.0.0b4, which is the primary
reason for the upgrade:

  ethereum/web3.py#1378
@ghost ghost deleted the live-test-fixes branch July 26, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants