Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBP DSL parser #53

Draft
wants to merge 40 commits into
base: master
Choose a base branch
from
Draft

FBP DSL parser #53

wants to merge 40 commits into from

Conversation

trustmaster
Copy link
Owner

Step 3 of #49, implementing FBP DSL parser in GoFlow itself

@trustmaster trustmaster added the WIP Work In Progress label Feb 4, 2019
@trustmaster trustmaster self-assigned this Feb 4, 2019
@codecov-io
Copy link

codecov-io commented Feb 4, 2019

Codecov Report

Merging #53 into master will decrease coverage by 7.95%.
The diff coverage is 72.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   91.75%   83.80%   -7.96%     
==========================================
  Files           6       11       +5     
  Lines         364      599     +235     
==========================================
+ Hits          334      502     +168     
- Misses         18       70      +52     
- Partials       12       27      +15     
Impacted Files Coverage Δ
dsl/tokenizer.go 0.00% <0.00%> (ø)
dsl/graph.go 53.84% <53.84%> (ø)
dsl/reader.go 80.00% <80.00%> (ø)
dsl/scanners.go 87.39% <87.39%> (ø)
dsl/collect.go 100.00% <100.00%> (ø)
factory.go 94.28% <0.00%> (-5.72%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d201b9...008065d. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2020

Codecov Report

Merging #53 into master will decrease coverage by 2.38%.
The diff coverage is 86.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   91.75%   89.37%   -2.39%     
==========================================
  Files           6       14       +8     
  Lines         364      715     +351     
==========================================
+ Hits          334      639     +305     
- Misses         18       44      +26     
- Partials       12       32      +20     
Impacted Files Coverage Δ
dsl/graph.go 52.38% <52.38%> (ø)
dsl/reader.go 80.00% <80.00%> (ø)
dsl/scanners.go 89.91% <89.91%> (ø)
dsl/tokenizer.go 91.80% <91.80%> (ø)
dsl/collect.go 100.00% <100.00%> (ø)
dsl/merge.go 100.00% <100.00%> (ø)
dsl/split.go 100.00% <100.00%> (ø)
dsl/start_token.go 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d201b9...13d16f4. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #53 (90d0f4a) into master (b48b2ee) will increase coverage by 0.62%.
The diff coverage is 90.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   89.43%   90.06%   +0.62%     
==========================================
  Files           6       14       +8     
  Lines         303      634     +331     
==========================================
+ Hits          271      571     +300     
- Misses         17       34      +17     
- Partials       15       29      +14     
Impacted Files Coverage Δ
graph.go 83.67% <ø> (ø)
dsl/reader.go 78.57% <78.57%> (ø)
dsl/tokenizer.go 88.70% <88.70%> (ø)
dsl/scanners.go 89.65% <89.65%> (ø)
dsl/graph.go 94.28% <94.28%> (ø)
dsl/collect.go 100.00% <100.00%> (ø)
dsl/merge.go 100.00% <100.00%> (ø)
dsl/split.go 100.00% <100.00%> (ø)
dsl/start_token.go 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48b2ee...90d0f4a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants