-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Filecoin support #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filecoin support #811
Conversation
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
==========================================
+ Coverage 90.09% 90.16% +0.06%
==========================================
Files 345 351 +6
Lines 11272 11457 +185
==========================================
+ Hits 10156 10330 +174
- Misses 1116 1127 +11
Continue to review full report at Codecov.
|
16af938 to
6e3fa34
Compare
|
Transaction generated by wallet-core now considered valid by Lotus node: Sample request to push transaction as base64 to node (requires filecoin-project/lotus#1108) {
"jsonrpc":"2.0",
"id":1,
"method":"Filecoin.MpoolPush",
"params":[
"gohVAYrJOEDoacBrebdIo8UEtpa7M5p/VQHPAb9IX2FDXmdwtSYVv0VeBDojYQFDABdwQgACQgDIAEBYQgFHe8+accnhmvd/vZJncjCpYS2SeHfkOetKowZDCk/65CJRGUgg3yEdAAdeiOaMlwSogESFMuwAkgRaHgDo8cu5AA=="
]
}Gas spent was 126. The node uses 1000 as the default value for Message correctly deserialized by Lotus node: |
|
@hewigovens I will add back |
|
@terorie Lmao, totally different order of magnitude |
d3b409e to
b03a970
Compare
Don't forget to update that in coins.json as well. |
|
@hewigovens , should this be done already using AnyAddress now? |
|
@terorie can you rebase master? we don't need to have a new C interface for filecoin address, we will adopt |
51b8666 to
0c8a23f
Compare
|
@vikmeup @hewigovens Transactions generated by wallet-core were successfully mined on testnet! CID of mined SignedMessage: It's ready for review+merge from my side. |
hewigovens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, left some comments (and there is one codacy warning)
optout21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks for all the reworks!
9ed8598 to
de5fdd2
Compare
|
@catenocrypt Good remarks, I fixed the remaining issues, squashed & rebased onto master! |
Description
Adds support for Filecoin, implementing a secp256k1-based wallet.
(Old PR #784)
Changes
Checklist
Closes #780.