-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-6342: Add ODH and RHOAI overlays #237
RHOAIENG-6342: Add ODH and RHOAI overlays #237
Conversation
@ruivieira: This pull request references RHOAIENG-6342 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
PR image build and manifest generation completed successfully! 📦 PR image: 🗂️ CI manifests |
cc @zdtsw |
i dont see problem with this PR, but wonder params.env will work for both ODH and RHOAI (for the future). |
@zdtsw thanks! The purpose of the RHOAI overlay is not to change the images themselves, but to add some RHOAI-specific configuration to the deployments in the future. |
@zdtsw: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danielezonca, zdtsw The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ruivieira: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
RHOAIENG-6342.
Add overlays specifically for ODH and RHOAI.