Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-6342: Add ODH and RHOAI overlays #237

Merged

Conversation

ruivieira
Copy link
Member

RHOAIENG-6342.

Add overlays specifically for ODH and RHOAI.

@ruivieira ruivieira added the kind/enhancement New feature or request label Apr 22, 2024
@ruivieira ruivieira self-assigned this Apr 22, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 22, 2024

@ruivieira: This pull request references RHOAIENG-6342 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

RHOAIENG-6342.

Add overlays specifically for ODH and RHOAI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:d1ba2d491e7c9b8486fd854cd7db7cdecbf19504

🗂️ CI manifests

@ruivieira
Copy link
Member Author

cc @zdtsw

@zdtsw
Copy link

zdtsw commented Apr 22, 2024

i dont see problem with this PR, but wonder params.env will work for both ODH and RHOAI (for the future).
maybe just keep params.env in the base,
and keep the overlay/odh and overlay/rhoai.
in the ODH case: base + overlay/odh
for the RHOAI case: base + overlay/rhoai.
you can keep updating base/params.env with your quay.io image for ODH
and we will take care of the internal build SHA1 in base/params.env for RHOAI.

@ruivieira
Copy link
Member Author

ruivieira commented Apr 22, 2024

i dont see problem with this PR, but wonder params.env will work for both ODH and RHOAI (for the future). maybe just keep params.env in the base, and keep the overlay/odh and overlay/rhoai. in the ODH case: base + overlay/odh for the RHOAI case: base + overlay/rhoai. you can keep updating base/params.env with your quay.io image for ODH and we will take care of the internal build SHA1 in base/params.env for RHOAI.

@zdtsw thanks! The purpose of the RHOAI overlay is not to change the images themselves, but to add some RHOAI-specific configuration to the deployments in the future.

Copy link

openshift-ci bot commented Apr 22, 2024

@zdtsw: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danielezonca, zdtsw

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Apr 22, 2024

@ruivieira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e d1ba2d4 link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ruivieira ruivieira merged commit b0eeed7 into trustyai-explainability:main Apr 22, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants