Code Review of a new Feature #590
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
| @@ -23,6 +23,31 @@ resource "aws_s3_bucket" "data" { | |||
| } | |||
| } | |||
|
|
|||
| resource "aws_s3_bucket" "data2" { | |||
There was a problem hiding this comment.
Ensure S3 Bucket has public access blocks
Resource: aws_s3_bucket.data2 | ID: BC_AWS_NETWORKING_52
How to Fix
resource "aws_s3_bucket" "bucket_good_1" {
bucket = "bucket_good"
}
resource "aws_s3_bucket_public_access_block" "access_good_1" {
bucket = aws_s3_bucket.bucket_good_1.id
block_public_acls = true
block_public_policy = true
}
Description
When you create an S3 bucket, it is good practice to set the additional resource **aws_s3_bucket_public_access_block** to ensure the bucket is never accidentally public.We recommend you ensure S3 bucket has public access blocks. If the public access block is not attached it defaults to False.
| @@ -23,6 +23,31 @@ resource "aws_s3_bucket" "data" { | |||
| } | |||
| } | |||
|
|
|||
| resource "aws_s3_bucket" "data2" { | |||
There was a problem hiding this comment.
Ensure S3 bucket has cross-region replication enabled
Resource: aws_s3_bucket.data2 | ID: BC_AWS_GENERAL_72
How to Fix
resource "aws_s3_bucket" "test" {
...
+ replication_configuration {
+ role = aws_iam_role.replication.arn
+ rules {
+ id = "foobar"
+ prefix = "foo"
+ status = "Enabled"
+
+ destination {
+ bucket = aws_s3_bucket.destination.arn
+ storage_class = "STANDARD"
+ }
+ }
+ }
}Description
Cross-region replication enables automatic, asynchronous copying of objects across S3 buckets. By default, replication supports copying new S3 objects after it is enabled. It is also possible to use replication to copy existing objects and clone them to a different bucket, but in order to do so, you must contact AWS Support.
terraform/aws/s3.tf
Outdated
| versioning { | ||
| enabled = "${var.versioning_enabled}" | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| server_side_encryption_configuration { | |
| rule { | |
| apply_server_side_encryption_by_default { | |
| sse_algorithm = "AES256" | |
| } | |
| } | |
| } | |
| } |
Ensure data stored in the S3 bucket is securely encrypted at rest
Resource: aws_s3_bucket.data2 | ID: BC_AWS_S3_14
Description
SSE helps prevent unauthorized access to S3 buckets. Encrypting and decrypting data at the S3 bucket level is transparent to users when accessing data.Benchmarks
- PCI-DSS V3.2 3
- NIST-800-53 AC-17, SC-2
- PCI-DSS V3.2.1 3.4
- FEDRAMP (MODERATE) SC-28
- CIS AWS V1.3 2.1.1
🎉 Fixed by commit 0440345 - Bridgecrew bot fix for terraform/aws/s3.tf
| @@ -23,6 +23,31 @@ resource "aws_s3_bucket" "data" { | |||
| } | |||
| } | |||
|
|
|||
| resource "aws_s3_bucket" "data2" { | |||
There was a problem hiding this comment.
PCI check tag exists
Resource: aws_s3_bucket.data2 | ID: acme_aws_1629787200891
| @@ -23,6 +23,31 @@ resource "aws_s3_bucket" "data" { | |||
| } | |||
| } | |||
|
|
|||
| resource "aws_s3_bucket" "data2" { | |||
There was a problem hiding this comment.
Visual Editor Policy Demo - S3 has a public-read ACL
Resource: aws_s3_bucket.data2 | ID: acme_aws_1628101837348
| @@ -23,6 +23,31 @@ resource "aws_s3_bucket" "data" { | |||
| } | |||
| } | |||
|
|
|||
| resource "aws_s3_bucket" "data2" { | |||
There was a problem hiding this comment.
Ensure AWS access logging is enabled on S3 buckets
Resource: aws_s3_bucket.data2 | ID: BC_AWS_S3_13
How to Fix
resource "aws_s3_bucket" "bucket" {
acl = var.s3_bucket_acl
bucket = var.s3_bucket_name
policy = var.s3_bucket_policy
force_destroy = var.s3_bucket_force_destroy
versioning {
enabled = var.versioning
mfa_delete = var.mfa_delete
}
+ dynamic "logging" {
+ for_each = var.logging
+ content {
+ target_bucket = logging.value["target_bucket"]
+ target_prefix = "log/${var.s3_bucket_name}"
+ }
+ }
}Description
Access logging provides detailed audit logging for all objects and folders in an S3 bucket.![prisma-cloud-devsecops[bot]](https://avatars.githubusercontent.com/in/135857?s=60&v=4){kind=small}
| @@ -23,6 +23,31 @@ resource "aws_s3_bucket" "data" { | |||
| } | |||
| } | |||
|
|
|||
| resource "aws_s3_bucket" "data2" { | |||
There was a problem hiding this comment.
AWS access logging not enabled on S3 buckets
Resource: aws_s3_bucket.data2 | ID: BC_AWS_S3_13
How to Fix
resource "aws_s3_bucket" "bucket" {
acl = var.s3_bucket_acl
bucket = var.s3_bucket_name
policy = var.s3_bucket_policy
force_destroy = var.s3_bucket_force_destroy
versioning {
enabled = var.versioning
mfa_delete = var.mfa_delete
}
+ dynamic "logging" {
+ for_each = var.logging
+ content {
+ target_bucket = logging.value["target_bucket"]
+ target_prefix = "log/${var.s3_bucket_name}"
+ }
+ }
}Description
Access logging provides detailed audit logging for all objects and folders in an S3 bucket.Benchmarks
- HIPAA 164.312(B) Audit controls
| @@ -23,6 +23,31 @@ resource "aws_s3_bucket" "data" { | |||
| } | |||
| } | |||
|
|
|||
| resource "aws_s3_bucket" "data2" { | |||
There was a problem hiding this comment.
S3 bucket cross-region replication disabled
Resource: aws_s3_bucket.data2 | ID: BC_AWS_GENERAL_72
How to Fix
resource "aws_s3_bucket" "test" {
...
+ replication_configuration {
+ role = aws_iam_role.replication.arn
+ rules {
+ id = "foobar"
+ prefix = "foo"
+ status = "Enabled"
+
+ destination {
+ bucket = aws_s3_bucket.destination.arn
+ storage_class = "STANDARD"
+ }
+ }
+ }
}Description
Cross-region replication enables automatic, asynchronous copying of objects across S3 buckets. By default, replication supports copying new S3 objects after it is enabled. It is also possible to use replication to copy existing objects and clone them to a different bucket, but in order to do so, you must contact AWS Support.
terraform/aws/s3.tf
Outdated
| versioning { | ||
| enabled = "${var.versioning_enabled}" | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| server_side_encryption_configuration { | |
| rule { | |
| apply_server_side_encryption_by_default { | |
| sse_algorithm = "AES256" | |
| } | |
| } | |
| } | |
| } |
Data stored in the S3 bucket is not securely encrypted at rest
Resource: aws_s3_bucket.data2 | ID: BC_AWS_S3_14
Description
SSE helps prevent unauthorized access to S3 buckets. Encrypting and decrypting data at the S3 bucket level is transparent to users when accessing data.Benchmarks
- FEDRAMP (MODERATE) SC-28
- CIS AWS V1.3 2.1.1
- NIST-800-53 SC-2, AC-17
- PCI-DSS V3.2 3
- PCI-DSS V3.2.1 3.4
🎉 Fixed by commit 0440345 - Bridgecrew bot fix for terraform/aws/s3.tf
| @@ -23,6 +23,31 @@ resource "aws_s3_bucket" "data" { | |||
| } | |||
| } | |||
|
|
|||
| resource "aws_s3_bucket" "data2" { | |||
There was a problem hiding this comment.
S3 Bucket does not have public access blocks
Resource: aws_s3_bucket.data2 | ID: BC_AWS_NETWORKING_52
How to Fix
resource "aws_s3_bucket" "bucket_good_1" {
bucket = "bucket_good"
}
resource "aws_s3_bucket_public_access_block" "access_good_1" {
bucket = aws_s3_bucket.bucket_good_1.id
block_public_acls = true
block_public_policy = true
}
Description
When you create an S3 bucket, it is good practice to set the additional resource **aws_s3_bucket_public_access_block** to ensure the bucket is never accidentally public.We recommend you ensure S3 bucket has public access blocks. If the public access block is not attached it defaults to False.
terraform/aws/s3.tf
Outdated
| versioning { | ||
| enabled = "${var.versioning_enabled}" | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| sse_algorithm = "aws:kms" |
S3 buckets are not encrypted with KMS
Resource: aws_s3_bucket.data2 | ID: BC_AWS_GENERAL_56
Description
TBA🎉 Fixed by commit de13086 - Bridgecrew bot fix for terraform/aws/s3.tf
terraform/aws/s3.tf
Outdated
| # bucket does not have access logs | ||
| # bucket does not have versioning | ||
| bucket = "${local.resource_prefix.value}-data" | ||
| acl = "public-read" |
There was a problem hiding this comment.
Suggested change
| acl = "public-read" |
Bucket ACL grants READ permission to everyone
Resource: aws_s3_bucket.data2 | ID: BC_AWS_S3_1
Description
Unprotected S3 buckets are one of the major causes of data theft and intrusions. An S3 bucket that allows **READ** access to everyone can provide attackers the ability to read object data within the bucket, which can lead to the exposure of sensitive data. The only S3 buckets that should be globally accessible for unauthenticated users or for **Any AWS Authenticate Users** are those used for hosting static websites. Bucket ACL helps manage access to S3 bucket data.We recommend AWS S3 buckets are not publicly accessible for READ actions to protect S3 data from unauthorized users and exposing sensitive data to public access.
Benchmarks
- NIST-800-53 AC-17
| @@ -23,6 +23,31 @@ resource "aws_s3_bucket" "data" { | |||
| } | |||
| } | |||
|
|
|||
| resource "aws_s3_bucket" "data2" { | |||
There was a problem hiding this comment.
Suggested change
| resource "aws_s3_bucket" "data2" { |
Ensure AWS S3 object versioning is enabled
Resource: aws_s3_bucket.data2 | ID: BC_AWS_S3_16
Description
S3 versioning is a managed data backup and recovery service provided by AWS. When enabled it allows users to retrieve and restore previous versions of their buckets.S3 versioning can be used for data protection and retention scenarios such as recovering objects that have been accidentally/intentionally deleted or overwritten.
Benchmarks
- PCI-DSS V3.2.1 10.5.3
- FEDRAMP (MODERATE) CP-10, SI-12
Calculating...
🎉 Fixed by commit de13086 - Bridgecrew bot fix for terraform/aws/s3.tf
| @@ -23,6 +23,31 @@ resource "aws_s3_bucket" "data" { | |||
| } | |||
| } | |||
|
|
|||
| resource "aws_s3_bucket" "data2" { | |||
There was a problem hiding this comment.
Suggested change
| resource "aws_s3_bucket" "data2" { |
AWS S3 object versioning is disabled
Resource: aws_s3_bucket.data2 | ID: BC_AWS_S3_16
Error in referred variable: variable "versioning_enabled"
Description
S3 versioning is a managed data backup and recovery service provided by AWS. When enabled it allows users to retrieve and restore previous versions of their buckets.S3 versioning can be used for data protection and retention scenarios such as recovering objects that have been accidentally/intentionally deleted or overwritten.
Benchmarks
- FEDRAMP (MODERATE) SI-12, CP-10
- PCI-DSS V3.2.1 10.5.3
🎉 Fixed by commit 9a7393b - Update s3.tf
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_S3_16 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2 BC_AWS_S3_14 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_S3_16 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2 BC_AWS_S3_14 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_56 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2 BC_AWS_S3_16 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_S3_16 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2 BC_AWS_GENERAL_56 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_S3_16 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2
Co-authored-by: bridgecrew[bot] <60663194+bridgecrew[bot]@users.noreply.github.com>
Co-authored-by: bridgecrew[bot] <60663194+bridgecrew[bot]@users.noreply.github.com>
| @@ -23,6 +23,38 @@ resource "aws_s3_bucket" "data" { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| resource "aws_s3_bucket" "data2" { | |||
There was a problem hiding this comment.
Ensure AWS access logging is enabled on S3 buckets
Resource: aws_s3_bucket.data2 | ID: BC_AWS_S3_13
How to Fix
resource "aws_s3_bucket" "bucket" {
acl = var.s3_bucket_acl
bucket = var.s3_bucket_name
policy = var.s3_bucket_policy
force_destroy = var.s3_bucket_force_destroy
versioning {
enabled = var.versioning
mfa_delete = var.mfa_delete
}
+ dynamic "logging" {
+ for_each = var.logging
+ content {
+ target_bucket = logging.value["target_bucket"]
+ target_prefix = "log/${var.s3_bucket_name}"
+ }
+ }
}Description
Access logging provides detailed audit logging for all objects and folders in an S3 bucket.Benchmarks
- HIPAA 164.312(B) Audit controls
Calculating...
🎉 Fixed by commit 8eef7fb - Update terraform/aws/s3.tf
| @@ -23,6 +23,38 @@ resource "aws_s3_bucket" "data" { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| resource "aws_s3_bucket" "data2" { | |||
There was a problem hiding this comment.
Ensure S3 bucket has cross-region replication enabled
Resource: aws_s3_bucket.data2 | ID: BC_AWS_GENERAL_72
How to Fix
resource "aws_s3_bucket" "test" {
...
+ replication_configuration {
+ role = aws_iam_role.replication.arn
+ rules {
+ id = "foobar"
+ prefix = "foo"
+ status = "Enabled"
+
+ destination {
+ bucket = aws_s3_bucket.destination.arn
+ storage_class = "STANDARD"
+ }
+ }
+ }
}Description
Cross-region replication enables automatic, asynchronous copying of objects across S3 buckets. By default, replication supports copying new S3 objects after it is enabled. It is also possible to use replication to copy existing objects and clone them to a different bucket, but in order to do so, you must contact AWS Support.Dependent Resources
Calculating...
🎉 Fixed by commit 8eef7fb - Update terraform/aws/s3.tf
| @@ -23,6 +23,38 @@ resource "aws_s3_bucket" "data" { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| resource "aws_s3_bucket" "data2" { | |||
There was a problem hiding this comment.
Visual Editor Policy Demo - S3 has a public-read ACL
Resource: aws_s3_bucket.data2 | ID: acme_aws_1628101837348
Dependent Resources
Calculating...
🎉 Fixed by commit 8eef7fb - Update terraform/aws/s3.tf
| @@ -23,6 +23,38 @@ resource "aws_s3_bucket" "data" { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| resource "aws_s3_bucket" "data2" { | |||
There was a problem hiding this comment.
PCI check tag exists
Resource: aws_s3_bucket.data2 | ID: acme_aws_1629787200891
Dependent Resources
Calculating...
🎉 Fixed by commit 8eef7fb - Update terraform/aws/s3.tf
| } | ||
| versioning { | ||
| enabled = "${var.versioning_enabled}" | ||
| } |
There was a problem hiding this comment.
Suggested change
| } |
Ensure AWS S3 object versioning is enabled
Resource: aws_s3_bucket.data2 | ID: BC_AWS_S3_16
Description
S3 versioning is a managed data backup and recovery service provided by AWS. When enabled it allows users to retrieve and restore previous versions of their buckets.S3 versioning can be used for data protection and retention scenarios such as recovering objects that have been accidentally/intentionally deleted or overwritten.
Benchmarks
- PCI-DSS V3.2.1 10.5.3
- FEDRAMP (MODERATE) CP-10, SI-12
Calculating...
🎉 Fixed by commit 8eef7fb - Update terraform/aws/s3.tf
| # bucket does not have access logs | ||
| # bucket does not have versioning | ||
| bucket = "${local.resource_prefix.value}-data" | ||
| force_destroy = true |
There was a problem hiding this comment.
Suggested change
| force_destroy = true |
Ensure bucket ACL does not grant READ permission to everyone
Resource: aws_s3_bucket.data2 | ID: BC_AWS_S3_1
Description
Unprotected S3 buckets are one of the major causes of data theft and intrusions. An S3 bucket that allows **READ** access to everyone can provide attackers the ability to read object data within the bucket, which can lead to the exposure of sensitive data. The only S3 buckets that should be globally accessible for unauthenticated users or for **Any AWS Authenticate Users** are those used for hosting static websites. Bucket ACL helps manage access to S3 bucket data.We recommend AWS S3 buckets are not publicly accessible for READ actions to protect S3 data from unauthorized users and exposing sensitive data to public access.
Benchmarks
- NIST-800-53 AC-17
Calculating...
🎉 Fixed by commit 8eef7fb - Update terraform/aws/s3.tf
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource acme_aws_1628101837348 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2 acme_aws_1629787200891 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2 BC_AWS_GENERAL_72 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2 BC_AWS_S3_1 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2 BC_AWS_S3_13 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2 BC_AWS_S3_16 Fixed /terraform/aws/s3.tf aws_s3_bucket.data2
schosterbarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.