-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat:Deprecate custom_topics and remove assemblyai/mistral-7b model #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/libs/AssemblyAI/openapi.yaml (1)
1450-1456
: Marking Custom Topics as Deprecated
Thecustom_topics
parameter in theTranscriptOptionalParams
schema is now explicitly marked as deprecated (via the addeddeprecated: true
line). This is a clear indication to users that the parameter is no longer recommended for use.If there is additional documentation or migration guidance for API consumers, please ensure it is updated accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
src/libs/AssemblyAI/Generated/AssemblyAI.Models.LemurModel.g.cs
is excluded by!**/generated/**
src/libs/AssemblyAI/Generated/AssemblyAI.Models.TranscriptOptionalParams.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/AssemblyAI/openapi.yaml
(1 hunks)
🔇 Additional comments (1)
src/libs/AssemblyAI/openapi.yaml (1)
5741-5749
:⚠️ Potential issueInconsistent Removal of the Mistral Model
According to the PR objectives and AI-generated summary, theassemblyai/mistral-7b
model should be removed from theLemurModel
enum. However, the block forassemblyai/mistral-7b
is still present in this file. Please verify whether this model should indeed be removed. If removal is intended, you can apply a diff similar to the one below:- assemblyai/mistral-7b: - description: > - LeMUR Mistral 7B is an LLM self-hosted by AssemblyAI. - It's the fastest and cheapest of the LLM options. We recommend it for use cases like basic summaries and factual Q&A. - casing: - camel: assemblyaiMistral7b - snake: assemblyai_mistral7b - pascal: AssemblyaiMistral7b - screamingSnake: ASSEMBLYAI_MISTRAL7BThis will align the implementation with the intended API changes.
Likely an incorrect or invalid review comment.
Summary by CodeRabbit