Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add inbox as default routing preference for custom delivery #501

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

joshshowalter
Copy link
Contributor

@joshshowalter joshshowalter commented Aug 28, 2023

Description

  • Currently if you click Customize Delivery Channel it will enable channels except inbox selected. This fixes this functionality to show inbox selected properly
  • fixes C-10211
image

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@263b066). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #501   +/-   ##
=======================================
  Coverage        ?   35.96%           
=======================================
  Files           ?       69           
  Lines           ?     1190           
  Branches        ?      362           
=======================================
  Hits            ?      428           
  Misses          ?      762           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshshowalter joshshowalter merged commit a7af4d9 into main Aug 28, 2023
@joshshowalter joshshowalter deleted the josh/enable-inbox-by-default branch August 28, 2023 21:33
@linear
Copy link

linear bot commented Aug 28, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants