feat(heap): Implement a simple string interner #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dean Srebnik <load1n9@users.noreply.github.com>
|
Got stuck trying to implement it using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quite simple implementation of a string interner as a
AHashMap<StringHeapData, StringIndex>lookup table. Seems to be broken and breaking tests, probably for a good reason. Ideally I would like the lookup table to not takeStringHeapDataas the key and instead take something like&'a strbut that would require a lifetime for the heap. Far from mergeable as is.Warning
Needs to be implemented using a
HashTable<...>instead. SeeMap/Setfor reference.Greatly speeds up operations where there are lots of strings.