feat(ecmascript): is_loosely_equal and is_strictly_equal #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
requested changes
Oct 31, 2023
nova_vm/src/ecmascript/abstract_operations/testing_and_comparison.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/abstract_operations/testing_and_comparison.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/abstract_operations/testing_and_comparison.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/abstract_operations/testing_and_comparison.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/abstract_operations/testing_and_comparison.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/abstract_operations/testing_and_comparison.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/abstract_operations/testing_and_comparison.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/abstract_operations/testing_and_comparison.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/abstract_operations/testing_and_comparison.rs
Outdated
Show resolved
Hide resolved
ghost
reviewed
Oct 31, 2023
ghost
reviewed
Oct 31, 2023
ghost
reviewed
Oct 31, 2023
ghost
reviewed
Oct 31, 2023
Co-authored-by: vimirage <vimirage@mirror.simplelogin.com>
|
LGTM besides the code splitting request (#53 (comment)). |
aapoalas
approved these changes
Nov 1, 2023
eliassjogreen
force-pushed
the
feat/is-strictly-or-loosely-equal
branch
from
773d8cb to
4990b6a
Compare
|
LGTM. Aapo should merge soon |
|
Thank you |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr implements the is_loosely_equal and is_strictly_equal operators.
is_loosely_equal still contains sometodo!s for the stuff I was unsure about, mostly having to do with bigint related operations.