feat(heap): Make number and string allocation functions unsafe #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Oct 31, 2023
ghost
reviewed
Oct 31, 2023
ghost
reviewed
Oct 31, 2023
ghost
reviewed
Oct 31, 2023
ghost
reviewed
Oct 31, 2023
ghost
reviewed
Oct 31, 2023
nova_vm/src/heap/number.rs
Outdated
| ), | ||
| ObjectEntry::new( | ||
| PropertyKey::from_str(heap, "MIN_SAFE_INTEGER"), | ||
| PropertyDescriptor::roh(Value::from_f64(heap, -9007199254740991.0)), | ||
| PropertyDescriptor::roh(heap.create(-9007199254740991.0).into()), |
ghost
reviewed
Oct 31, 2023
ghost
reviewed
Oct 31, 2023
aapoalas
force-pushed
the
feat/unsafe-heap-alloc-functions
branch
from
17e2101 to
88ab98a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions do not check the invariants that the parameters must keep to, so they're naturally unsafe.
I had to also refactor the way the
Numberenum is instantiated.