Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webassembly) fix varint decoding message #62

Merged
merged 4 commits into from Nov 24, 2023
Merged

fix(webassembly) fix varint decoding message #62

merged 4 commits into from Nov 24, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2023

Resolves #17

I think the code is all wrong. Eventually I'm going to read the entire spec and implement it myself here <.<

Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails :(

test varint::test::decode_32_over_u32_max ... FAILED

@aapoalas aapoalas enabled auto-merge (squash) November 24, 2023 18:13
@aapoalas aapoalas merged commit 3fde04b into trynova:main Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasm | varint - incorrect counts for expected bytes
1 participant