Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(builtins): more Number constructor methods #66

Merged
merged 5 commits into from
Nov 24, 2023
Merged

feat(builtins): more Number constructor methods #66

merged 5 commits into from
Nov 24, 2023

Conversation

sno2
Copy link
Contributor

@sno2 sno2 commented Nov 4, 2023

Now, we only need to finish the Number constructor, Number.parseFloat, and Number.parseInt.

@sno2
feat(builtins): more Number constructor methods
92bf472 
Now, we only need to finish the `Number` constructor,
`Number.parseFloat`, and `Number.parseInt`.
@sno2 sno2 changed the title feat(builtins): more Number constructor methods feat(builtins): more Number constructor methods Nov 4, 2023
aapoalas
aapoalas requested changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for SafeInteger check which can be done with a direct enum check. Admittedly, that's a bit of a nitpick but eh.

nova_vm/src/ecmascript/builtins/number.rs Show resolved Hide resolved
nova_vm/src/ecmascript/builtins/number.rs Outdated Show resolved Hide resolved
@sno2 sno2 enabled auto-merge (squash) November 8, 2023 13:56
@sno2 sno2 disabled auto-merge November 9, 2023 23:21
@sno2 sno2 enabled auto-merge (squash) November 9, 2023 23:21
@sno2 sno2 merged commit 641ba69 into main Nov 24, 2023
@aapoalas aapoalas deleted the feat/number-builtins branch December 24, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sno2 @aapoalas