[fix] Display better error messages when checking Retool version #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertchang
approved these changes
Sep 5, 2024
ph-ph
deleted the
dzmitry/gov-3834-better-error-message-when-version-check-fails-with
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We check Retool version when initializing provider. Unfortunately, the way the version check function is implemented, we produce "incompatible version" error message even when we fail to connect to Retool or parse its healthcheck response, which is confusing for our users .
This change updates the code to produce meaningful error messages on connection errors and failure to parse the response.
Tests
Verified that the version check still works as expected and produces meaningful error messages when it can't connect to Retool.