Skip to content

Changed getter style to say "getter must have no side effects" #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaufgang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changed getter style to say "getter must have no side effects" #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions style.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,11 +547,9 @@ should use `public`, but AngularJS should use `protected`.
> Warning: Getters and setters have to be transpiled into bloated code.
> It is a good practice to avoid using getters and setters in general.

Getters and setters for class members may be used. The getter method must be a
[pure function](https://en.wikipedia.org/wiki/Pure_function) (i.e., result is
consistent and has no side effects). They are also useful as a means of
restricting the visibility of internal or verbose implementation details (shown
below).
Getters and setters for class members may be used. The getter method must have
no side effects. They are also useful as a means of restricting the visibility
of internal or verbose implementation details (shown below).

```ts {.good}
class Foo {
Expand Down