-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add SKOSMOS integration #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
syphax-bouazzouni
requested changes
Jul 17, 2024
@rombaum fixed the |
syphax-bouazzouni
approved these changes
Jul 22, 2024
rombaum
reviewed
Jul 22, 2024
rombaum
reviewed
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. There is just this small request if we could directly use the information from the API instead of a static value.
c24dff0
to
fb0670a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the integration of the SLOSMOS search API to our API-Gateway.
Changes
1- Federated Search over ols,skosmos and ontoportal
Now by default, the search will be federated over ols (ebi), ontoportal(biodivportal) and skosmos(agrovoc) , for example this request
http://localhost:8080/api-gateway/federatedSearch?query=milk*&targetDbSchema=ols
will returnFor OLS:
For OntoPortal
And now also SKOSMOS
2- Output results to SKOSMOS format
Doing

http://localhost:8080/api-gateway/federatedSearch?query=milk*&targetDbSchema=skosmos
, will output all the results in the skosmos formatBellow an example of results:
Format mappings
@id