Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List instantiation replaced with asList #409

Open
pouryafard75 opened this issue Mar 16, 2023 · 2 comments
Open

List instantiation replaced with asList #409

pouryafard75 opened this issue Mar 16, 2023 · 2 comments

Comments

@pouryafard75
Copy link
Collaborator

google/truth@1768840

image

image
tsantalis added a commit that referenced this issue Apr 11, 2023
@tsantalis
Fix for issue #409
e08a746
@tsantalis
Copy link
Owner

@pouryafard75

In introduced sub-expression mappings instead of a CompositeReplacement with additionally matched statements,
because in the second case the add method call names were matched with containsNoDuplicates

Screenshot from 2023-04-10 20-49-20

@pouryafard75
Copy link
Collaborator Author

pouryafard75 commented Apr 29, 2023 •
edited
Loading

@tsantalis The problem with the list instantiation has been resolved. However, I believe this issue must be re-opened since we discussed the iterable() method is inlined.

@tsantalis tsantalis reopened this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsantalis @pouryafard75