Missing Inline Variable refactoring

[pedramnoori]

Problem

Missing Inline Variable refactoring happened within an Extract and Move Method refactoring. Similar to #461 and #462, and related to #443

Commit

FasterXML/jackson-databind@da29a04

Refactoring

Extract And Move Method public serialize(gen JsonGenerator, value Object, prov DefaultSerializerProvider) : void extracted from public writeValue(gen JsonGenerator, value Object) : void in class com.fasterxml.jackson.databind.ObjectWriter & moved to class com.fasterxml.jackson.databind.ObjectWriter.Prefetch

Description

The problem is that an Inline Variable refactoring has been reported within the bodyMapper of the aforementioned Extract and Move Method. But, it has not been reported in the original list of refactorings (modelDiff.getRefactorings()). The Inline Variable refactoring is as follows:

Inline Variable ser : JsonSerializer in method public writeValue(gen JsonGenerator, value Object) : void from class com.fasterxml.jackson.databind.ObjectWriter

Also note that the information of this refactoring is crucial to report the Extract and Move method as a pure case (to justify the ser -> valueSerializer replacement). So far, I handled this issue on my side by iterating over the refactorings reported in the bodyMappers. Since I found this refactoring as a valid case, I thought it would be better to report this refactoring within the actual list.