Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline variable can’t be detected in some cases #678

Closed
simpt5 opened this issue Mar 16, 2024 · 2 comments
Closed

Inline variable can’t be detected in some cases #678

simpt5 opened this issue Mar 16, 2024 · 2 comments

Comments

@simpt5
Copy link

simpt5 commented Mar 16, 2024

Tested tools and version:

Refactoring Aware Commit Review Chrome Extension (Version: 2.0.4).
RefactoringMiner (Version 3.0.4) maven dependency.

Description:

During the usage of RefactoringMiner, I found a few inline variable refactoring cases that can’t be detected. Do you have any idea why this happens and how to resolve this problem?

Commit URL:
discoStar711/job-finder@4559aa1

The following inline variable refactoring in the above commit can’t be detected.

image
image

The same situation also happens in the following commit:
RefactoringGuru/design-patterns-java@74514fe

The inline variable refactoring following can’t be detected too:

image

@tsantalis
Copy link
Owner

Related to issue #154

tsantalis added a commit that referenced this issue Mar 16, 2024
Fixes only missed Inline Variable in commit
discoStar711/job-finder@4559aa1
tsantalis added a commit that referenced this issue Mar 17, 2024
@tsantalis
Copy link
Owner

@simpt5
Thank you for reporting all these issues. We greatly appreciate this.
This issue has been fixed. The Inline Variable refactorings are now detected in both commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants