-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: include --nojekyll option flag #468
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
12a187e
include option for CNAME domain
freitzzz 0f9ff17
create CNAME file with domain provided by option if flag is not undef…
freitzzz a82cf08
include test for CNAME option
freitzzz cb18fe9
include --nojekyll option flag
freitzzz 993dff5
typo
freitzzz 7b1a8a4
Merge pull request #2 from freitzzz/1-config-cname-flag
freitzzz 21e4d05
Merge branch 'main' into 3-config-no-jekyll
freitzzz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ const log = util.debuglog('gh-pages'); | |
*/ | ||
function getCacheDir(optPath) { | ||
const dir = findCacheDir({name: 'gh-pages'}); | ||
|
||
if (!optPath) { | ||
return dir; | ||
} | ||
|
@@ -40,6 +41,8 @@ exports.defaults = { | |
git: 'git', | ||
depth: 1, | ||
dotfiles: false, | ||
cname: undefined, | ||
nojekyll: false, | ||
branch: 'gh-pages', | ||
remote: 'origin', | ||
src: '**/*', | ||
|
@@ -113,6 +116,14 @@ exports.publish = function publish(basePath, config, callback) { | |
return; | ||
} | ||
|
||
if (options.cname) { | ||
fs.writeFileSync(path.join(basePath, 'CNAME'), options.cname); | ||
} | ||
|
||
if (options.nojekyll) { | ||
fs.createFileSync(path.join(basePath, '.nojekyll')); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same above as above about writing to the |
||
|
||
let repoUrl; | ||
let userPromise; | ||
if (options.user) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will result in the
CNAME
file being written to thedest
directory (which may be a subdirectory not at the root of the repo). I think it should be written to the root instead.