Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support path input from Buffer on many fs APIs #293

Merged
merged 1 commit into from
Apr 21, 2020
Merged

fix: support path input from Buffer on many fs APIs #293

merged 1 commit into from
Apr 21, 2020

Conversation

3cp
Copy link
Collaborator

@3cp 3cp commented Apr 20, 2020 •
edited
Loading

There is missing support of "path <string> | <Buffer> | <URL>" on many fs APIs.

closes #292

@3cp 3cp mentioned this pull request Apr 20, 2020
Closed
@3cp 3cp requested a review from tschaub April 20, 2020 04:20
@3cp
Copy link
Collaborator Author

3cp commented Apr 20, 2020

@tschaub something wrong with your travis account? The CI didn't start.

@3cp
Copy link
Collaborator Author

3cp commented Apr 20, 2020 •
edited
Loading

We can move from travis to github actions (which supports win10 and macOS too), if you wanna remove the dependency on travis.

sindilevich
sindilevich reviewed Apr 20, 2020
View reviewed changes
Copy link

@sindilevich sindilevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest refactoring the Buffer stringification out to a utility function. Then, all other places would use the function's result in their code flow.

lib/binding.js Outdated Show resolved Hide resolved
@3cp 3cp force-pushed the recursive-rmdir branch from 371df21 to 039c467 Compare April 20, 2020 08:38
@tschaub
Copy link
Owner

tschaub commented Apr 20, 2020

We can move from travis to github actions (which supports win10 and macOS too), if you wanna remove the dependency on travis.

Good suggestion. Please rebase now that #296 is in.

@3cp
fix: support path input from Buffer on many fs APIs
0f98ca5 
There is missing support of "path <string> | <Buffer> | <URL>" on many fs APIs.

closes #292
@3cp 3cp force-pushed the recursive-rmdir branch from 039c467 to 0f98ca5 Compare April 20, 2020 22:15
@3cp
Copy link
Collaborator Author

3cp commented Apr 20, 2020

Passed checks.

@tschaub
Copy link
Owner

tschaub commented Apr 21, 2020

Thanks, @3cp!

@tschaub tschaub merged commit bc04178 into master Apr 21, 2020
@tschaub tschaub deleted the recursive-rmdir branch April 21, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindilevich sindilevich sindilevich left review comments

@tschaub tschaub tschaub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fs.rmdir looks not support "recursive"
3 participants
@3cp @tschaub @sindilevich