docs: fix some minor errors #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschoffelen
reviewed
Jul 14, 2023
Comment on lines
-233
to
+234
| // appTitles: { 'google-maps': 'My custom Google Maps title' }, // optionally you can override default app titles | ||
| // app: 'uber', // optionally specify specific app to use | ||
| appTitles: { 'google-maps': 'My custom Google Maps title' }, // optionally you can override default app titles | ||
| app: 'uber', // optionally specify specific app to use |
There was a problem hiding this comment.
I think the idea here was the disable these by default, in case someone just copies the code snippet without looking and is confused about the fact that a specific app is opened rather than showing the list of options.
But maybe that means we should have a short simple example and then one that shows all the available options?
There was a problem hiding this comment.
Oops sorry I ignored your reply before.
We already have "optionally" comments after these options. Other optional options are not commented, so IMO it could be better to keep these 2 options consistent, i.e. uncommented.
tschoffelen
approved these changes
Jan 2, 2024
|
Thanks for your contribution @meteorlxy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.