Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior change after bumping up to 1.6.0 from 1.4.9 #408

Open
jayasuryat opened this issue Jul 1, 2024 · 1 comment
Open

Behavior change after bumping up to 1.6.0 from 1.4.9 #408

jayasuryat opened this issue Jul 1, 2024 · 1 comment

Comments

@jayasuryat
Copy link

I have updated the library version from 1.4.9 to 1.6.0, along with updates to Kotlin and KSP versions:
Kotlin version: 1.7.0 -> 1.9.24
KSP version: 1.7.0-1.0.6 -> 1.9.24-1.0.20

Issue

After these updates, I have observed a change in the compilation results. In some instances where the result was previously KotlinCompilation.ExitCode.OK, it is now returning KotlinCompilation.ExitCode.COMPILATION_ERROR.

This new result is logical since it returns KotlinCompilation.ExitCode.COMPILATION_ERROR in scenarios where an error log is produced in the Symbol processor implementation. (Otherwise the code compiles successfully)


Question

Do you have insights into whether this behavior change was introduced by the newer library version, KSP, or the Kotlin Compiler itself?


Reproduction

I have created a minimal project that reproduces the behavior. The test that passed before the version updates is now failing after updating the versions: jayasuryat/KspBehaviorChangeIssue#1

jayasuryat added a commit to jayasuryat/dowel that referenced this issue Jul 2, 2024
@tschuchortdev
Copy link
Owner

If I had to guess, it is probably related to internal changes in the compiler and/or KSP. At least I couldn't find any commit since 1.4.9 that would influence the error handling. There have been issues with errors originating in KSP processors before, so perhaps the new behaviour actually fixes #325?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants