feat: Detect the number of issues created that have a bounty #17
Conversation
|
@seveibar can u please review sir. |
|
@seveibar added a test which show this image |
scripts/test-github-issues.ts
Outdated
| // Function to extract bounty amount from comment body | ||
| function extractBountyAmountFromComment( | ||
| commentBody: string | undefined, | ||
| ): number { |
There was a problem hiding this comment.
Import code under test, dont redefine it
There was a problem hiding this comment.
Goes for almost this entire file
There was a problem hiding this comment.
@seveibar done.
Signed-off-by: Anshgrover23 <168731971+Anshgrover23@users.noreply.github.com>
|
Your screenshot doesnt show any users that have a bounty amount greater than 0, try shibo |
lib/getBountiedIssues.ts
Outdated
| } | ||
|
|
||
| // Fetch bountied issues for a specific contributor | ||
| export async function fetchBountiedIssues( |
There was a problem hiding this comment.
Function name should match file name
|
@seveibar done. |
|
@seveibar see more photo for reference: for user(shibo) |
lib/getBountiedIssues.ts
Outdated
|
|
||
| // Extract the bounty amount from the bot's comment | ||
| const amount = botComment && botComment.body ? extractBountyAmountFromComment(botComment.body) : 0 | ||
| console.log(botComment?.body); |
There was a problem hiding this comment.
| console.log(botComment?.body); |
|
@Anshgrover23 can you show the result of actually generating the table? It's been broken in the past by people not fully testing, i'd like to make sure it actually generates the table properly. |
|
@seveibar can u tell uniform streamlined way to check this? like i did not find anything in readme.md regarding this.
|
|
Remember that when you PR code, it is expected that you've run the code, never PR code you haven't run. I've actually only ever suspended one contributor from tscircuit, and it was for not running their code and repeatedly introducing bugs. So this is a very critical/important thing to do. |
|
@seveibar Herre is the current Progress Now it is working. |
|
@Anshgrover23 I don't think the data is correct, see the issues created column. It's 0 for all |
|
@imrishabh18 i am making fix for it |
|
@imrishabh18 @seveibar done. you can see now. |
|
@seveibar thanks. |
/claim #15
Fixes #15