Skip to content

svg stroke width scaling #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

svg stroke width scaling #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54f9186
Fix line strokeWidth scaling in SVG output
seveibar Mar 5, 2025
62c999b
update test snapshots
seveibar Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/getSvgFromGraphicsObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export function getSvgFromGraphicsObject(graphics: GraphicsObject): string {
.join(" "),
fill: "none",
stroke: line.strokeColor || "black",
"stroke-width": (line.strokeWidth || 1).toString(),
"stroke-width": ((line.strokeWidth || 1) / Math.abs(matrix.a) * DEFAULT_SVG_SIZE / 100).toString(),
},
})),
// Rectangles
Expand Down
4 changes: 2 additions & 2 deletions tests/__snapshots__/lines.snap.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/__snapshots__/renderer-graphics.snap.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 1 addition & 3 deletions tests/getSvgFromGraphicsObject.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,8 @@ describe("getSvgFromGraphicsObject", () => {
expect(svg).toBeString()
expect(svg).toContain("<polyline")
// Test custom stroke properties
expect(svg).toContain('stroke-width="2"')
expect(svg).toContain('stroke="blue"')
// Test default values
expect(svg).toContain('stroke-width="1"')
// Don't test for exact stroke-width values as they're scaled based on the matrix
expect(svg).toContain('stroke="black"')
expect(svg).toMatchSvgSnapshot(import.meta.path, "lines")
})
Expand Down