Add animationKey to allow animated graphics #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seveibar
commented
Mar 6, 2025
seveibar
commented
- Add animationKey support for Line and Point components
- Fix Line and Point animations using requestAnimationFrame
- Fix Line and Point animations with stable component keys
This change enables smooth animations for Lines and Points in InteractiveGraphics when they have an animationKey property. Elements with the same animationKey will animate smoothly to their new positions instead of jumping. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Replace CSS transitions with frame-by-frame animation using requestAnimationFrame for smoother animation of lines and points in InteractiveGraphics. This ensures that Line elements properly animate between positions when they have animationKey. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This change properly handles animations for Line and Point components by: 1. Preserving component identity across renders using stable React keys based on animationKey 2. Simplifying the animation fixture to demonstrate functionality correctly 3. Keeping animationKeys consistent for each element 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.