-
Notifications
You must be signed in to change notification settings - Fork 55
fix: resolve local dev api not working #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@devroy10 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
|
@seveibar ready for a review |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
can you consolidate this logic into something like |
yeah, sure. Should this util be stored in |
|
sure |
to be on the right side, in addition to |
a95391c to
5fc6cd4
Compare
|
@seveibar @imrishabh18 changes made, ready for a review now |
Problem
The previous implementation used:
This logic is flawed:
truebecause of the!… || !…combination.Solution
This PR fixes this faulty check pattern that was introduced in PR #898
tscircuit_runframe-small.mp4
videolink here
Impact
example04,example05) where the local API never initialized./claim #1100