-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Node 16 moduleResolution to "Node16" #121
Comments
It is a good question of when people might expect esm projects to be the default, but I'm not quite sure that is right now. I'm open to having a separate node16+esm (we already have a node16+strictest+esm for example) but I don't think changing the default is a good call for maybe a few years |
+1 on a |
Sure thing, add it |
If module is set to commonjs, moduleResolution can be set to node16 to allow import/export maps to work properly while still emitting cjs |
Actually, that seems to not even be required. https://www.typescriptlang.org/tsconfig#module I'm using node16 in the beta branch for TypeDoc and am getting cjs output as expected. |
In typescript 5.2 it is an error to have Currently with 5.2 the Looks like |
This happened in #197 |
Issue
Current moduleResolution value is "node". This doesn't seem to support "exports" in package.json.
Possible Solution
Change moduleResolution to "Node16" seems appropriate. A quick test overriding the value after extending this configuration seems to solve the issue.
The text was updated successfully, but these errors were encountered: