Update module and moduleResolution to stop using node and invalid combintations #197

andrewbranch · 2023-06-21T23:23:46Z

Per microsoft/TypeScript#54567 and microsoft/TypeScript#54735, I’m planning to make it an error to mix node16 module/moduleResolution with non-matching values for the other field. I’m also taking this opportunity to replace node (which is for Node 10!) with bundler where applicable.

…binations

andrewbranch · 2023-06-21T23:24:37Z

bases/docusaurus.json

@@ -8,7 +8,8 @@
 "esModuleInterop": true,
 "jsx": "react",
 "lib": ["DOM"],
- "moduleResolution": "Node16",
+ "module": "esnext",
+ "moduleResolution": "bundler",


Related: #196 and facebook/docusaurus#9050 (comment)

andrewbranch · 2023-06-21T23:29:28Z

bases/esm.json

@@ -4,6 +4,7 @@

 "compilerOptions": {
 "module": "es2022",
+ "moduleResolution": "bundler",


I strongly object to this base existing at all. It’s a trap that might prevent a user from finding the config they should be using for Node or Vite or whatever.

I delisted it in the latest commit.

Is the suggested approach to now use base/node18 and then set moduleResolution manually in tsconfig.json to bundler?

andrewbranch · 2023-06-21T23:30:45Z

bases/node12.json

 "target": "es2019",

 "strict": true,
 "esModuleInterop": true,
 "skipLibCheck": true,
 "forceConsistentCasingInFileNames": true,
- "moduleResolution": "node"
+ "moduleResolution": "node16"


The changes reflected in node16 are mostly present as of Node v12.

orta · 2023-06-22T19:27:52Z

This all makes sense to me!

"moduleResolution": "bundler" might be a feature which came out on a later version of typescript, so I think we'll need to bump some versions (I think I need to start doing semver minors on these node builds) and that 👍🏻

andrewbranch · 2023-06-22T19:38:04Z

Yeah, it’s pretty new (5.0). I noticed some _version fields but I didn’t get how they were used. Do they just control the version of the published npm package?

orta · 2023-06-22T19:47:31Z

I'll do it, and I'll ping a few folks who should at least see this coming through:

@styfle (you might want this change in nextjs too)
@chriskrycho (this raises the lowest TS support to 5.0, is this something you are intentional about?) we can do a major server for your tsconfig version too
@dummdidumm (I don't think this should be too breaky for you?)
I don't think nuxt/remix are used in a more official capacity, so shouldn't worry too much there

I'll give it a few days before a merge, and I've sent you an invite to be a collab too

dummdidumm · 2023-06-22T21:01:17Z

Svelte change looks good to me 👍

styfle · 2023-06-23T01:16:13Z

bases/next.json

@@ -11,7 +11,7 @@
 "noEmit": true,
 "esModuleInterop": true,
 "module": "esnext",
- "moduleResolution": "node",
+ "moduleResolution": "bundler",


This would be a breaking change in Next.js since its only TS 5+

While we're at it, we could probably remove target since Next.js doesn't use it.

Also include looks outdated since its missing ".next/types/**/*.ts"

You can find the latest with create next app

styfle · 2023-06-23T01:18:52Z

bases/node20.json

@@ -11,6 +11,6 @@
 "esModuleInterop": true,
 "skipLibCheck": true,
 "forceConsistentCasingInFileNames": true,
- "moduleResolution": "node"
+ "moduleResolution": "node16"


Should this be nodenext instead?

No, it should match the module setting above (the linked PR on TS would enforce it). At the moment, node16 is nodenext, as no new resolution semantics have been introduced. Eventually maybe there will be a node24 if that version changes something.

Related, but "node" was renamed to "node10" for that reason.

chriskrycho · 2023-06-23T03:08:19Z

bases/ember.json

@@ -2,15 +2,15 @@
 "$schema": "https://json.schemastore.org/tsconfig",
 "display": "Ember",
 "docs": "https://docs.ember-cli-typescript.com",
- "_version": "2.0.0",
+ "_version": "2.1.0",


As suggested on the main discussion, it would be helpful for us to treat this as 3.0.0 if it’s explicitly bumping the minimum TS version. However, I have not fully taken on the overall approach here. If (per the README change) it is going going to be effectively bumped with every release, we may need to reevaluate the approach. Ember itself is also at a point where we could poeple finally look at just shipping an @ember/tsconfig instead, inverting this and leaving Ember in control of those bumps. I will dig in further and chat with the rest of the team and follow up!

Happy with whatever works for you - could bump to 4.x because that matches the LTS of embed for example too?

Let's just go with a clean major for now:

Suggested change

"_version": "2.1.0",

"_version": "3.0.0",

Medium-term, I think we'll probably end up switching to an @ember/tsconfig.json so we can manage our own versioning scheme with it (that makes good sense for how we're approaching Ember's own SerVer commitments re: TS support).

orta · 2023-06-27T17:22:32Z

Cool, I think this is everything then 👍🏻

I've bumped the majors on all of the affected bases and noted why the esm build is deprecated

andrewbranch · 2023-06-27T17:38:20Z

Thanks all!

orta · 2023-07-03T06:41:15Z

For folks coming to this thread trying to figure to some of the types, I'd recommend looking at https://arethetypeswrong.github.io/

joeythomaschaske · 2023-08-11T17:17:42Z

Ran into a ton of problems with this change. Typescript recommends using node as the moduleResolution value

https://www.typescriptlang.org/docs/handbook/module-resolution.html#module-resolution-strategies

Note: node module resolution is the most-commonly used in the TypeScript community and is recommended for most projects. If you are having resolution problems with imports and exports in TypeScript, try setting moduleResolution: "node" to see if it fixes the issue.

andrewbranch · 2023-08-11T17:19:11Z

That page is many years out of date and will be deleted / completely rewritten soon.

andrewbranch added 4 commits June 21, 2023 16:20

Update module and moduleResolution to stop using node and invalid com…

a8c454f

…binations

bundler needs nodenext

449f1c9

Update node12

b1eae8c

bundler needs esnext

700981c

andrewbranch commented Jun 21, 2023

View reviewed changes

Delist esm.json

7f15ea0

Bump some versions

7301ec5

styfle reviewed Jun 23, 2023

View reviewed changes

chriskrycho reviewed Jun 23, 2023

View reviewed changes

chriskrycho and others added 2 commits June 27, 2023 08:46

Bump @tsconfig/ember version to 3.0.0

4fd7c96

Major semver to all of them

f2fd2b6

orta merged commit 014e892 into tsconfig:main Jun 27, 2023
1 check passed

andrewbranch deleted the update-module-resolution branch June 27, 2023 17:38

andykenward mentioned this pull request Jun 28, 2023

fix: export type information for node16 module resolution jonschlinkert/is-plain-object#28

Open

Techn1x mentioned this pull request Jun 29, 2023

Incorrect export of core types percy/cli#1290

Closed

orta mentioned this pull request Jul 4, 2023

Change Node 16 moduleResolution to "Node16" #121

Closed

aloisklink mentioned this pull request Jul 5, 2023

build(deps-dev): bump @tsconfig/node14 from 1.0.3 to 14.1.0 mermaid-js/mermaid-cli#558

Merged

orta mentioned this pull request Jul 10, 2023

Understanding Versioning of TSConfigs #203

Closed

kachick mentioned this pull request Jul 12, 2023

Update tsconfig that is a missing task in updating to Node.js 20 mobu-of-the-world/emobu#367

Closed

orta mentioned this pull request Jul 14, 2023

Update node20.json to match the same semver as the other nodes #205

Merged

orta mentioned this pull request Aug 14, 2023

inconsistent case for "module" field in node bases #209

Closed

chshouyu mentioned this pull request Aug 21, 2023

Where should the option "veratimmodulesyntax" be placed? #211

Closed

jasonaowen mentioned this pull request Aug 25, 2023

Bump typescript from 5.1.6 to 5.2.2 PhilanthropyDataCommons/service#460

Merged

kachkaev mentioned this pull request Sep 8, 2023

Remove @tsconfig/esm kachkaev/njt#440

Merged

markuskullberg-sanoma mentioned this pull request Oct 5, 2023

README instructions about ESM is invalid #224

Closed

orta mentioned this pull request Oct 13, 2023

Reasoning behind removing the ESM config #228

Closed

trivikr mentioned this pull request Feb 19, 2024

Bump @tsconfig/node14 to 14.1.0 aws/aws-sdk-js-codemod#761

Merged

academo mentioned this pull request Feb 22, 2024

Migrate Levitate to ESM grafana/levitate#423

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update module and moduleResolution to stop using node and invalid combintations #197

Update module and moduleResolution to stop using node and invalid combintations #197

andrewbranch commented Jun 21, 2023

andrewbranch Jun 21, 2023

andrewbranch Jun 21, 2023

andrewbranch Jun 21, 2023

johnf Jul 3, 2023

andrewbranch Jun 21, 2023

orta commented Jun 22, 2023

andrewbranch commented Jun 22, 2023

orta commented Jun 22, 2023 •

edited

Loading

dummdidumm commented Jun 22, 2023

styfle Jun 23, 2023 •

edited

Loading

styfle Jun 23, 2023

jakebailey Jun 23, 2023 •

edited

Loading

chriskrycho Jun 23, 2023 •

edited

Loading

orta Jun 23, 2023

chriskrycho Jun 27, 2023

orta commented Jun 27, 2023 •

edited

Loading

andrewbranch commented Jun 27, 2023

orta commented Jul 3, 2023

joeythomaschaske commented Aug 11, 2023

andrewbranch commented Aug 11, 2023

Update module and moduleResolution to stop using node and invalid combintations #197

Update module and moduleResolution to stop using node and invalid combintations #197

Conversation

andrewbranch commented Jun 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

orta commented Jun 22, 2023

andrewbranch commented Jun 22, 2023

orta commented Jun 22, 2023 • edited Loading

dummdidumm commented Jun 22, 2023

styfle Jun 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakebailey Jun 23, 2023 • edited Loading

Choose a reason for hiding this comment

chriskrycho Jun 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

orta commented Jun 27, 2023 • edited Loading

andrewbranch commented Jun 27, 2023

orta commented Jul 3, 2023

joeythomaschaske commented Aug 11, 2023

andrewbranch commented Aug 11, 2023

orta commented Jun 22, 2023 •

edited

Loading

styfle Jun 23, 2023 •

edited

Loading

jakebailey Jun 23, 2023 •

edited

Loading

chriskrycho Jun 23, 2023 •

edited

Loading

orta commented Jun 27, 2023 •

edited

Loading