Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README instructions about ESM is invalid #224

Closed
markuskullberg-sanoma opened this issue Oct 5, 2023 · 1 comment
Closed

README instructions about ESM is invalid #224

markuskullberg-sanoma opened this issue Oct 5, 2023 · 1 comment

Comments

@markuskullberg-sanoma
Copy link

The README states that:

What about @tsconfig/esm?
We deprecated it in favour of setting #197 to node/bundler.

However, TS complains about that combination Option 'bundler' can only be used when 'module' is set to 'es2015' or later.:
Screenshot 2023-10-05 at 10 40 32

What is the correct combination for a Node project that uses a bundler? For example, Node lambdas are often packaged with esbuild, so this should be quite a common thing.
@orta
Copy link
Member

orta commented Oct 7, 2023

Afraid I don't have the time to walk people through their tsconfig setups, you're welcome to ask on stack overflow

@orta orta closed this as completed Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orta @markuskullberg-sanoma