node-ts: Align with Node docs (for discussion) #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns node-ts.json with the recommended tsconfig in the Node docs for built-in *.ts support https://nodejs.org/api/typescript.html#type-stripping
jakebailey
reviewed
Mar 2, 2025
| @@ -4,6 +4,10 @@ | |||
| "docs": "https://devblogs.microsoft.com/typescript/announcing-typescript-5-8-beta/#the---erasablesyntaxonly-option", | |||
| "_version": "23.6.0", | |||
| "compilerOptions": { | |||
| "target": "esnext", | |||
There was a problem hiding this comment.
This file was supposed to be a mixin placed at the end of an extends list: the TS extension thing seems good but I'm not sure about overriding the target or module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns
node-ts.jsonwith the recommended tsconfig in the Node docs for built-in*.tssupport.https://nodejs.org/api/typescript.html#type-stripping
I realize this was discussed two months ago in #293 but I missed that first time around and reading it back, it doesn't seem to directly answer the question of why these are not aligned. So please consider this a low-urgency discussion topic rather than something to be landed.