Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expectError): report missing diagnostic codes #178

Merged
merged 3 commits into from
Mar 10, 2023
Merged

fix(expectError): report missing diagnostic codes #178

merged 3 commits into from
Mar 10, 2023

Conversation

tommy-mitchell
Copy link
Contributor

@tommy-mitchell tommy-mitchell commented Mar 9, 2023 •
edited
Loading

Implements #177 (comment).

expectError now behaves in three ways:

  • If an error is a syntactic error (diagnostic code less than 2000), don't display Expected an error message
  • If no error exists, log Expected an error, but found none.
  • Otherwise, log Found an error that tsd does not currently support (tsXXXX), consider creating an issue on GitHub.

@tommy-mitchell
Copy link
Contributor Author

Should probably also document in the readme that syntax errors can’t be ignored.

@sindresorhus sindresorhus merged commit b4503d0 into tsdjs:main Mar 10, 2023
@sindresorhus
Copy link
Collaborator

Thanks :)

@tommy-mitchell tommy-mitchell mentioned this pull request Aug 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommy-mitchell @sindresorhus