Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browser output #254

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Fix browser output #254

merged 2 commits into from
Sep 18, 2024
+236 −50

Conversation

Romakita
Copy link
Collaborator

Informations

Type  Status Migration
Fix Ready No

Description

Remove node util.format usage in the code

Todos

  • Tests
  • Coverage
  • Example
  • Documentation

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10919344546

Details

  • 74 of 79 (93.67%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 91.625%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/logger/src/node/layouts/LayoutReplacer.ts 60 65 92.31%
Totals Coverage Status
Change from base Build 10182196402: -0.03%
Covered Lines: 453
Relevant Lines: 477
💛 - Coveralls

@Romakita Romakita merged commit e6572b8 into production Sep 18, 2024
12 checks passed
@Romakita Romakita deleted the fix-browser-output branch September 18, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Romakita @coveralls