Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema,core): Fix controller inheritance #1545

Merged
merged 1 commit into from
Sep 28, 2021
Merged

fix(schema,core): Fix controller inheritance #1545

merged 1 commit into from
Sep 28, 2021

Conversation

Romakita
Copy link
Collaborator

Information

Type Breaking change
Feature/Fix/Doc/Chore Yes/No

Todos

  • Tests
  • Coverage
  • Example
  • Documentation

@Romakita Romakita force-pushed the fix-1535-inheritance-ctrl branch from 2ace524 to 2ff2644 Compare September 28, 2021 08:24
@Romakita Romakita force-pushed the fix-1535-inheritance-ctrl branch from 2ff2644 to 6036432 Compare September 28, 2021 08:35
@github-actions
Copy link

Benchmark result

tsed vs express: New benchmarks generated
tsed-koa vs koa: New benchmarks generated.

Note:
Average of all diffs for Ts.ED-* so: (0.15 + 0.14 + 0.12 + 0.12) / 4

Details:

Req/sec Trans/sec Req/sec DIFF Trans/sec DIFF
Ts.ED Express 1617 453.23KB - -
Ts.ED Koa 1938 386.01KB - -
Nest-Express 2677 624.82KB - -
Nest-Fastify 6383 1.07MB - -
Express 2952 688.90KB - -
Express Router 3013 703.16KB - -
Koa 6583 1.10MB - -
Fastify 6947 1.17MB - -

Note:
req/sec DIFF and Trans/sec DIFF is in comparison to the baseline on target branch (master).

@Romakita Romakita merged commit 8427456 into production Sep 28, 2021
@Romakita Romakita deleted the fix-1535-inheritance-ctrl branch September 28, 2021 13:08
@Romakita
Copy link
Collaborator Author

🎉 This PR is included in version 6.72.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Romakita Romakita mentioned this pull request Sep 29, 2021
Closed
1 task
@Romakita
Copy link
Collaborator Author

Romakita commented Oct 9, 2021

🎉 This PR is included in version 7.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released 🚀 released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Romakita