Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style 2 #357

Merged
merged 7 commits into from
May 7, 2018
Merged

Code style 2 #357

merged 7 commits into from
May 7, 2018

Conversation

troyanskiy
Copy link
Contributor

Informations

Type  Status Migration
Fix Ready No

Description

Implementation of new rules and code refactoring.

Rules added

  • prefer-const
  • newline-before-return
  • no-angle-bracket-type-assertion
  • only-arrow-functions
  • arrow-return-shorthand
  • object-literal-shorthand
  • array-type
  • variable-name

@troyanskiy
Copy link
Contributor Author

@Romakita Could you please have a look at my commits... Nothing dangerous, just code styling and rules on tslint.

@troyanskiy troyanskiy mentioned this pull request May 6, 2018
Closed
9 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e5dab7f on code-style-2 into e399d1d on master.

1 similar comment
@coveralls
Copy link

coveralls commented May 6, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e5dab7f on code-style-2 into e399d1d on master.

@troyanskiy
Copy link
Contributor Author

@Romakita does it mean that I can merge the pull request?
What do you prefer?

  • Create marge commit
  • Squash
  • Rebase

@Romakita Romakita merged commit c5138d8 into master May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Romakita Romakita Romakita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@troyanskiy @coveralls @Romakita