Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line argument for passing in adapter #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nileshpatra
Copy link

Currently, ADAPTERS path path is hard-coded and users need to manually modify this variable if the file is placed elsewhere.
It might be a better idea if users could pass-in file path via command line argument --adapters
If no such command line argument is passed, it'd default to the original implementation i.e. finding it in <location of binary>/../db/trimmomatic.fa (the original implementation)

This is an attempt to implement the functionality and I've tested this.

@nileshpatra
Copy link
Author

@tseemann could you please review this?

@nileshpatra
Copy link
Author

@tseemann gentle ping, Could you please review this?

@nileshpatra
Copy link
Author

Gentle ping on this?

CC: @tseemann @andersgs

@nileshpatra
Copy link
Author

@tseemann @andersgs ping again :-)

Full context: I maintain this package in debian. And for people only be able to use the package, by 'manually' editing /usr/bin/shovill in the current setting.
Hence, it'd be nice if you could merge this please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant