Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disable-keepalive flag #89

Closed
jpfuentes2 opened this issue Nov 6, 2014 · 1 comment · Fixed by #91
Closed

Add disable-keepalive flag #89

jpfuentes2 opened this issue Nov 6, 2014 · 1 comment · Fixed by #91

Comments

@jpfuentes2
Copy link
Contributor

The service I'm testing almost exclusively deals with short-lived, single request connections. With no option to disable keepalive I cannot run tests which properly simulate my production environment.

Would you accept a PR with a -disable-keepalive flag?
@tsenart
Copy link
Owner

tsenart commented Nov 6, 2014

I would definitely accept a patch for this flag, but I would simply call it keepalive.

jpfuentes2 added a commit to jpfuentes2/vegeta that referenced this issue Nov 6, 2014
@jpfuentes2
Add -keepalive flag to toggle persistent conns
f2a4a59 
The flag is enabled by default.

closes tsenart#89
@jpfuentes2 jpfuentes2 mentioned this issue Nov 6, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add -keepalive flag to toggle persistent conns jpfuentes2/vegeta
2 participants
@tsenart @jpfuentes2