Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support targets with inline bodies similar to shell's "here tag" #260

Closed
wants to merge 3 commits into from

Conversation

1u0
Copy link

@1u0 1u0 commented Sep 18, 2017

Hi, this is an updated PR of the effort done by @coxx in #148.

The change will allow vegeta to read body payloads from the same target data stream.

@1u0
Copy link
Author

1u0 commented Oct 12, 2017

@tsenart please consider this functionality, maybe not as it is done in this PR but at least in general.

The use case is when there are multitude of different request bodies in the payloads. It would be convenient to have payload in one file (or generated dynamically and passed through stdin), instead of having a lot of scattered files.

@matthewbrookes
Copy link

Hi I'm interested to know what is the status of this?

@matthewbrookes
Copy link

I see the commits are from quite some time ago, I'm happy doing the work to rebase etc for merging into master

@tsenart
Copy link
Owner

tsenart commented Jun 27, 2018

@mbrookes1304: I'm reviewing the implementation and thinking through the design now.

@matthewbrookes
Copy link

@tsenart that's great, from the issue I opened I think you can see it's a very useful feature. Please let me know if there's any thing I can do to help :) I'm quite keen to make an open source Go contribution

@tsenart tsenart mentioned this pull request Jun 29, 2018
3 tasks
@tsenart
Copy link
Owner

tsenart commented Jul 5, 2018

Superseded by #300.

@tsenart tsenart closed this Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants