Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Add CMIS Host Management Files to 'show techsupport' Dumps #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tshalvi
Copy link
Owner

@tshalvi tshalvi commented Aug 22, 2024

What I did

I added the following CMIS host management-related files to the 'show techsupport' dumps (if they exist):
sai.profile, pmon_daemon_control.json, media_settings.json, optics_si_settings.json.

How I did it

How to verify it

Run 'show techsupport' and verify that the files are present in the following path within the generated dump: /etc/cmis-host-mgmt.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@tshalvi tshalvi changed the title Added CMIS host management-related files to the show techsupport dumps Add CMIS Host Management Files to 'show techsupport' Dumps Aug 22, 2024
@tshalvi tshalvi changed the title Add CMIS Host Management Files to 'show techsupport' Dumps [Mellanox] Add CMIS Host Management Files to 'show techsupport' Dumps Aug 22, 2024
scripts/generate_dump Outdated Show resolved Hide resolved
scripts/generate_dump Outdated Show resolved Hide resolved
scripts/generate_dump Outdated Show resolved Hide resolved
@tshalvi tshalvi requested a review from DavidZagury August 25, 2024 14:39
local hwsku=$(python3 -c "from sonic_py_common import device_info; print(device_info.get_hwsku())")
local sku_folder="/usr/share/sonic/device/${platform}/${hwsku}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
local sku_folder="/usr/share/sonic/device/${platform}/${hwsku}"
local sku_folder="${platform_folder}/${hwsku}"

scripts/generate_dump Outdated Show resolved Hide resolved
Copy link

@DavidZagury DavidZagury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the save_cmd functions to save the output of a commnad

…nd used save_cmd() instead of running the command directly and manually storing the output in a file
scripts/generate_dump Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants