Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'scIsConnected()' method to API to make application connection waiting more flexible. #51

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

jekyll2014
Copy link

Making my C# app I found it more comfortable to use the flag instead of the stopper method.

@tshino
Copy link
Owner

tshino commented Jan 16, 2024

Hi! @jekyll2014 ,
Thank you very much!
I agree this was a missing feature and must be useful for certain situations.

@tshino
Copy link
Owner

tshino commented Jan 16, 2024

It seems you forgot to commit another changed file SenderAPI.h.
Would you please add the file? Then I can merge this PR.

@jekyll2014
Copy link
Author

jekyll2014 commented Jan 16, 2024

Domo origato!

Hi! @jekyll2014 , Thank you very much! I agree this was a missing feature and must be useful for certain situations.

I'll also try to check if it's possible to detect the application disconnected event... This will be very useful too.
And as far as I can understand the camera name could be set from the caller...

It seems you forgot to commit another changed file SenderAPI.h. Would you please add the file? Then I can merge this PR.

My bad. Sorry, that's my first commit on GitHub (never tried it for the past 10 years). Will fix it surely.

@tshino tshino merged commit 217c254 into tshino:main Jan 16, 2024
3 checks passed
tshino added a commit that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants