Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: connect to remote media player #121

Merged
merged 39 commits into from
Jan 11, 2023
Merged

feat: connect to remote media player #121

merged 39 commits into from
Jan 11, 2023

Conversation

tsirysndr
Copy link
Owner

No description provided.

@tsirysndr tsirysndr added the enhancement New feature or request label Dec 11, 2022
@tsirysndr tsirysndr self-assigned this Dec 11, 2022
@codecov
Copy link

codecov bot commented Dec 11, 2022 •
edited
Loading

Codecov Report

Base: 54.48% // Head: 48.90% // Decreases project coverage by -5.57% ⚠️

Coverage data is based on head (e99ea16) compared to base (ffe7e7c).
Patch coverage: 22.57% of modified lines in pull request are covered.

❗ Current head e99ea16 differs from pull request most recent head a0d343b. Consider uploading reports for the commit a0d343b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   54.48%   48.90%   -5.58%     
==========================================
  Files          90      103      +13     
  Lines       10706    12243    +1537     
==========================================
+ Hits         5833     5988     +155     
- Misses       4873     6255    +1382
Impacted Files Coverage Δ
addons/src/datpiff.rs 0.00% <0.00%> (ø)
addons/src/deezer.rs 0.00% <0.00%> (ø)
addons/src/kodi.rs 0.00% <0.00%> (ø)
addons/src/local.rs 0.00% <0.00%> (ø)
addons/src/myvazo.rs 0.00% <0.00%> (ø)
audio/src/fetch/client.rs 0.00% <0.00%> (ø)
audio/src/fetch/receive.rs 0.00% <0.00%> (ø)
audio/src/range_set.rs 0.00% <0.00%> (ø)
client/src/playlist.rs 0.00% <0.00%> (ø)
entity/src/album.rs 63.33% <0.00%> (-23.04%) ⬇️
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 18, 2022
View reviewed changes
discovery/src/lib.rs
use std::thread;

use music_player_settings::{read_settings, Settings};

pub const SERVICE_NAME: &'static str = "_music-player._tcp.local.";
pub const XBMC_SERVICE_NAME: &'static str = "_xbmc-jsonrpc-h._tcp.local.";

Check warning

Code scanning / clippy

constants have by default a `'static` lifetime

constants have by default a `'static` lifetime
@tsirysndr tsirysndr force-pushed the feat/remote-connect branch 8 times, most recently from 0d86a85 to a1a3932 Compare December 25, 2022 05:35
@tsirysndr tsirysndr force-pushed the feat/remote-connect branch 5 times, most recently from 1066c6d to e99ea16 Compare December 30, 2022 11:30
@tsirysndr tsirysndr force-pushed the feat/remote-connect branch 3 times, most recently from bae76fb to c9bc280 Compare January 10, 2023 19:34
@tsirysndr
chore: fix bazel build
f91423c
@tsirysndr
chore: update cargo-bazel-lock.json
9033fdf
@tsirysndr
chore(bazel): fix rust-embed build issues
65b2b96
@tsirysndr
refacto: add reusable entity repositories
29c6b39
@tsirysndr
feat(api): add pagination
623f2e6
@tsirysndr
chore(webui): fix broken storybook
5b85084 
chore(webui): fix broken storybook
@tsirysndr
feat(graphql): return trait Box<dyn Browseable + Send> instead inst…
f8f3836 
…ead of `Local` object
@tsirysndr
feat(graphql): optimize remote device connection
9cb6976
@tsirysndr
feat(graphql): return remote track url
e9e1fb2
@tsirysndr
feat(graphql): use RemoteTrackUrl and RemoteCoverUrl traits
5cf798f
@tsirysndr
styles(webui): change connect button colors
39a4a95
@tsirysndr
feat(audio): implement streaming from http(s) url
4bc943e
@tsirysndr
feat(audio): add AudioFile::Local enum
7f204df
@tsirysndr
feat(playback): use AudioFile from music-player-audio crate
557f17e 
[playback] refactor track loader

refacto: use repo crates
@tsirysndr
chore: fix broken tests
c00cb0b 
chore: fix broken tests

chore: fix broken tests

chore: fix broken tests
@tsirysndr
feat: improve remote connect
afebede
@tsirysndr
feat: implement remote media cache feature
84e4951
@tsirysndr
fix(webui): resolve issue with cover url
f9cf66f
@tsirysndr
fix(graphql): resolve issue with remote track url
ee20f5d
@tsirysndr
chore(bazel): fix bazel issue
6bdfaad 
chore(bazel): fix bazel issue

chore(bazel): fix bazel issue
@tsirysndr
fix(graphql): resolve issue with cover url
b54959c
@tsirysndr
fix(graphql): resolve issue with cover url (artist's tracks)
d2ad9ee
@tsirysndr
fix(server): return complete artist's albums
0c9b063
@tsirysndr
fix(types): return artist's song remote cover url
5363f36
@tsirysndr
fix(server): re-generate proto
6b5a92c 
fix(server): re-generate proto
@tsirysndr
feat(webui): call connectToDevice and disconnectFormDevice queries
cf150c0
@tsirysndr
feat(webui): show Snackbar on connnected/disconnected to a device
12903fa
@tsirysndr tsirysndr force-pushed the feat/remote-connect branch from a0d343b to 12903fa Compare January 11, 2023 19:04
@tsirysndr tsirysndr merged commit 5f12420 into master Jan 11, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 11, 2023
View reviewed changes
settings/src/lib.rs
fs::create_dir_all(&albums).unwrap();
fs::create_dir_all(&artists).unwrap();
fs::create_dir_all(&playlists).unwrap();
fs::create_dir_all(&tracks).unwrap();
fs::create_dir_all(&covers).unwrap();
fs::create_dir_all(&cache).unwrap();

Check warning

Code scanning / clippy

the borrowed expression implements the required traits

the borrowed expression implements the required traits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tsirysndr tsirysndr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tsirysndr