Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

カウントダウン付きのメインコンテンツを実装 #20

Merged
merged 6 commits into from
Nov 24, 2024

Conversation

masayaO
Copy link
Collaborator

@masayaO masayaO commented Nov 24, 2024

実装したこと

  • カウントダウンコンポーネントのUIを調整
  • メインコンテンツのUIを調整
  • デザインレビュー用に「スポンサー募集開始」セクションも表示

やってないこと

パーフェクトピクセルでは作ってないのでFigmaと比べて多少ズレがあります。この修正をmainブランチに反映後、クリエイティブチームにデザインレビューを出して調整します!

関連資料

https://www.figma.com/design/JKCppXvTVKtFGRa6hNYXBz/Web%E3%83%87%E3%82%B6%E3%82%A4%E3%83%B3?node-id=1-647&t=f7J4cQrNtAj3SmET-1

画像

image

image

image

@masayaO masayaO self-assigned this Nov 24, 2024
@masayaO masayaO requested a review from kp047i November 24, 2024 09:43
Copy link
Contributor

@kp047i kp047i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masayaO masayaO merged commit ce17975 into main Nov 24, 2024
1 check passed
@masayaO masayaO deleted the feature/countdown-banner branch November 24, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants