Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

デザインレビューの指摘修正 v1 #23

Merged
merged 7 commits into from
Nov 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,16 @@ type Props = {
value: number;
unit: string;
duration: string;
isTabular?: boolean;
};

export function TimeLeft({ value, unit, duration }: Props) {
export function TimeLeft({ value, unit, duration, isTabular = false }: Props) {
return (
<div className="text-center w-[50px] md:w-[100px]">
<time
className="block text-3xl md:text-5xl lg:text-6xl font-semibold md:font-normal tracking-[-0.75%]"
className={`block text-3xl md:text-5xl lg:text-6xl font-semibold md:font-normal tracking-[-0.75%] ${
isTabular ? "tabular-nums" : ""
}`}
dateTime={duration}
>
{value}
Expand Down
5 changes: 3 additions & 2 deletions src/components/EventCountdownBanner/CountdownTimer/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export function CountdownTimer() {
const { timeLeft } = useCountdownTimer();

return (
<div className="relative w-[330px] md:w-[600px] lg:w-[630px] h-[142px] md:h-[154px] lg:h-[182px] bg-primary rounded-lg flex items-center justify-center shadow-[0_4px_6px_rgba(0,0,0,0.09)] overflow-hidden">
<div className="relative w-[330px] md:w-[600px] lg:w-[630px] h-[142px] md:h-[154px] lg:h-[182px] bg-primary rounded-2xl flex items-center justify-center shadow-[0_4px_6px_rgba(0,0,0,0.09)] overflow-hidden">
<div
className="absolute -top-[130px] lg:-top-[90px] -left-[100px] lg:-left-[90px] w-40 h-40 bg-[#ED82B0] rotate-45"
style={{
Expand Down Expand Up @@ -50,7 +50,7 @@ export function CountdownTimer() {
<Divider />
<TimeLeft
value={timeLeft.hours}
unit="Hour"
unit="Hours"
duration={`PT${timeLeft.hours}H`}
/>
<Divider />
Expand All @@ -64,6 +64,7 @@ export function CountdownTimer() {
value={timeLeft.seconds}
unit="Seconds"
duration={`PT${timeLeft.seconds}S`}
isTabular={true}
/>
</div>
</div>
Expand Down
16 changes: 8 additions & 8 deletions src/components/EventCountdownBanner/GridBackground/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@ export function GridBackground() {
linear-gradient(90deg, hsl(var(--primary)) 2px, transparent 2px)
`,
mask: `radial-gradient(
ellipse 80% 50% at center 40%,
black 30%,
black 30%,
transparent 65%
ellipse 70% 60% at center,
black 20%,
black 20%,
transparent 60%
)`,
WebkitMask: `radial-gradient(
ellipse 80% 50% at center 40%,
black 30%,
black 30%,
transparent 65%
ellipse 70% 60% at center,
black 20%,
black 20%,
transparent 60%
)`,
}}
/>
Expand Down
29 changes: 23 additions & 6 deletions src/components/EventCountdownBanner/index.tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { ChevronDown } from "lucide-react";
import { CountdownTimer } from "./CountdownTimer";
import { GridBackground } from "./GridBackground";

export function EventCountdownBanner() {
return (
<div className="w-full h-[644px] lg:h-[850px] relative flex flex-col items-center justify-center gap-10 text-center">
<div className="w-full h-[674px] lg:h-[790px] relative flex flex-col items-center text-center">
<GridBackground />

<img
Expand All @@ -12,16 +13,32 @@ export function EventCountdownBanner() {
alt="logo"
/>

<CountdownTimer />
<div className="mt-[178px] lg:mt-[248px]">
<CountdownTimer />
</div>

<div className="text-2xl font-semibold space-y-1">
<time dateTime="2025-05-23">5/23, 5/24</time>
<p>ベルサール神田</p>
<div className="mt-[52px] text-2xl font-semibold space-y-1">
<time
dateTime="2025-05-23"
className="text-[28px] leading-[36px] tracking-[-.75%] font-semibold"
>
5/23, 5/24
</time>
<p className="text-[23px] leading-[36px] tracking-[-.75%] font-bold">
ベルサール神田
</p>
</div>

<h1 className="text-5xl font-bold text-primary w-96 lg:w-full">
<h1 className="mt-[30px] lg:mt-[40px] text-[50px] lg:text-[59px] leading-[48px] tracking-[-1.2%] font-bold text-primary w-96 lg:w-full">
TSKaigi 2025 Coming Soon
</h1>

<div className="mt-[46px] lg:mt-[74px] flex flex-col items-center">
<span className="text-xl leading-[25px] tracking-[-1.2%] font-semibold lg:font-bold text-primary">
Scroll
</span>
<ChevronDown className="h-4 w-4 text-primary" />
</div>
</div>
);
}
6 changes: 4 additions & 2 deletions src/components/SeekingSponsorsSection/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ import Link from "next/link";

export function SeekingSponsorsSection() {
return (
<div className="w-full flex flex-col items-center gap-8 px-8 pb-16">
<h2 className="text-3xl font-bold text-center">スポンサー募集開始</h2>
<div className="w-full flex flex-col items-center gap-8 px-8 pt-10 pb-16">
<h2 className="text-[32px] lg:text-4xl leading-[48px] tracking-[-1.2%] font-bold text-center">
スポンサー募集開始
</h2>
<div>
<p>
一緒にTypeScriptコミュニティを盛り上げていただけるスポンサー企業を募集いたします。
Expand Down